Add a flag for enabling the threaded parser

Add a flag for enabling the threaded parser

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182284

[abarth-chromium, 2013-02-12 00:53:18]

I'm not sure if this CL is right.  Thoughts?

[tony, 2013-02-12 00:58:27]

Do you want this to show up in about:flags?  Alternately, do you want to bundle
this with --enable-webkit-experimental-features?

If the answer to both of those questions are 'No', then this LGTM, although
you'll need OWNERS approval for content.

[abarth-chromium, 2013-02-12 01:03:24]

> Do you want this to show up in about:flags?

Eventually.  I was going to try that in a second pass.

> Alternately, do you want to bundle
> this with --enable-webkit-experimental-features?

I'm not sure it makes sense to bundle it since it's not a developer-facing
feature.  It's also likely to be pretty broken for a bit.

> If the answer to both of those questions are 'No', then this LGTM, although
> you'll need OWNERS approval for content.

Thanks!

[abarth-chromium, 2013-02-12 01:03:59]

+darin for OWNERS review.

[abarth-chromium, 2013-02-12 18:37:13]

@jam: I can haz OWNER review?

[darin (slow to review), 2013-02-12 19:21:05]

LGTM

[abarth-chromium, 2013-02-12 19:27:09]

Thanks!

[commit-bot: I haz the power, 2013-02-12 19:29:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/12223082/1

[abarth-chromium, 2013-02-13 03:55:12]

Is 8 hours, 25 minutes a normal amount of time for the commit-bot to process a
patch?

[darin (slow to review), 2013-02-13 07:04:50]

I think I saw someone reporting that the CQ was delayed by ~9 hours today.
 I've seen big delays during peak MTV hours, but that seems unusually bad
to me.

-Darin


On Tue, Feb 12, 2013 at 7:55 PM, <abarth@chromium.org> wrote:

> Is 8 hours, 25 minutes a normal amount of time for the commit-bot to
> process a
> patch?
>
>
https://chromiumcodereview.**appspot.com/12223082/<https://chromiumcodereview...
>

[macdome_gmail.com, 2013-02-13 07:28:36]

On 2013/02/13 07:04:50, darin wrote:
> I think I saw someone reporting that the CQ was delayed by ~9 hours today.
>  I've seen big delays during peak MTV hours, but that seems unusually bad
> to me.
> 
> -Darin

By contrast... waiting 1hr is a long time to wait for the WebKit commit-queue.
:(
http://queues.webkit.org/queue-charts/commit-queue

> On Tue, Feb 12, 2013 at 7:55 PM, <mailto:abarth@chromium.org> wrote:
> 
> > Is 8 hours, 25 minutes a normal amount of time for the commit-bot to
> > process a
> > patch?
> >
> >
>
https://chromiumcodereview.**appspot.com/12223082/%3Chttps://chromiumcoderevi...>
> >

[abarth-chromium, 2013-02-13 07:46:00]

Add a flag for enabling the threaded parser

[commit-bot: I haz the power, 2013-02-13 19:36:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/12223082/1011

[commit-bot: I haz the power, 2013-02-13 19:36:37]

Failed to apply patch for content/browser/web_contents/web_contents_impl.cc:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file content/browser/web_contents/web_contents_impl.cc
  Hunk #1 FAILED at 532.
  1 out of 1 hunk FAILED -- saving rejects to file
content/browser/web_contents/web_contents_impl.cc.rej

Patch:       content/browser/web_contents/web_contents_impl.cc
Index: content/browser/web_contents/web_contents_impl.cc
===================================================================
--- content/browser/web_contents/web_contents_impl.cc	(revision 182155)
+++ content/browser/web_contents/web_contents_impl.cc	(working copy)
@@ -532,6 +532,8 @@
       command_line.HasSwitch(switches::kEnableExperimentalWebKitFeatures);
   prefs.record_rendering_stats =
       command_line.HasSwitch(switches::kEnableGpuBenchmarking);
+  prefs.threaded_html_parser =
+      command_line.HasSwitch(switches::kEnableThreadedHTMLParser);
 
   bool touch_device_present = false;
   touch_device_present = ui::IsTouchDevicePresent();

[jochen (gone - plz use gerrit), 2013-02-27 07:30:19]

fyi, this patch is incomplete.

The setting will never make it to the renderer. To work, the new struct
parameter needs to be added to the IPC definition as well

[abarth-chromium, 2013-02-27 08:00:15]

On 2013/02/27 07:30:19, jochen wrote:
> fyi, this patch is incomplete.
> 
> The setting will never make it to the renderer. To work, the new struct
> parameter needs to be added to the IPC definition as well

I'm not surprised.  :)

[darin (slow to review), 2013-02-27 08:25:54]

Whoops, yes... sorry about that.  You need to modify
content/public/common/common_param_traits_macros.h