Create generated tests inside the build directory

tools/test.dart

Index: tools/test.dart
diff --git a/tools/test.dart b/tools/test.dart
index 12cff100c5a64c6acbc267704e242cb41a0f82d5..da3a85e48fa89865378538ed2f7a2b658f9843ae 100755
--- a/tools/test.dart
+++ b/tools/test.dart
@@ -126,6 +126,10 @@ main() {
   }
 
   var testSuites = new List<TestSuite>();
+  // FIXME(kustermann,ricow): This is boken and should be fixed ASAP.

[Emily Fortuna, 2013/02/16 02:22:01]

nit: typo -- broken

[kustermann, 2013/02/18 09:27:02]

Done.

+  // Issue: 8366
+  TestingServerRunner.setBuildDir(firstConf);
+  TestingServerRunner.setPackageRootDir(firstConf);

[Emily Fortuna, 2013/02/16 02:22:01]

I don't understand this change. Why move line 137 up here?

[kustermann, 2013/02/18 09:27:02]

Well, there are two things here (I don't know which one you are refering to):

 a) We need to (currently) call TestingServerRunner.setBuilddDir and
TestingServerRunner.setPackageRootDir (ricow started this, and I haven't
modified this).

 b) The old code has these calls inside the for loop (line 137): Now this could
lead people to the (wrong!) conclusion that this works -- but it doesn't work:
Since the variables in TestingServerRunner are all static, we call
'setPackageRootDir' multiple times and only the last call will have an effect.
By putting these calls before the for loop, I explicitly! state that we
currently use only the first configuration (and I addded a FIXME to change
that).

[Emily Fortuna, 2013/02/19 17:50:19]

Sgtm. I was referring to line 132, the line I commented on, but was misreading
that, and thought that that loop was executed throughout running the tests
instead of before.  

   var maxBrowserProcesses = maxProcesses;
   for (var conf in configurations) {
     // There should not be more than one InternetExplorerDriver instance
@@ -134,7 +138,6 @@ main() {
     if (conf['runtime'].startsWith('ie')) {
       maxBrowserProcesses = 1;
     }
-    TestingServerRunner.setPackageRootDir(conf);
     for (String key in selectors.keys) {
       if (key == 'co19') {
         testSuites.add(new Co19TestSuite(conf));