src/objects.cc - Issue 12223071: ES6 symbols: Introduce Symbol class, along with abstract Name class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 12223071: ES6 symbols: Introduce Symbol class, along with abstract Name class (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 45153ee0edbb759425442a5b4bb69a3c998f567e..6e388dcbb9a2db0614d488bf6c7ed8785184be90 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -1318,6 +1318,9 @@ void HeapObject::HeapObjectShortPrint(StringStream* accumulator) {

accumulator->Add("<Odd Oddball>");

break;

}

+ case SYMBOL_TYPE:

+ accumulator->Add("<Symbol: %d>", Symbol::cast(this)->Hash());

+ break;

case HEAP_NUMBER_TYPE:

accumulator->Add("<Number: ");

HeapNumber::cast(this)->HeapNumberPrint(accumulator);

@@ -1426,6 +1429,7 @@ void HeapObject::IterateBody(InstanceType type, int object_size,

case JS_GLOBAL_PROPERTY_CELL_TYPE:

JSGlobalPropertyCell::BodyDescriptor::IterateBody(this, v);

break;

+ case SYMBOL_TYPE:

case HEAP_NUMBER_TYPE:

case FILLER_TYPE:

case BYTE_ARRAY_TYPE:

« no previous file with comments | « src/objects.h ('k') | src/objects-debug.cc » ('j') | no next file with comments »