Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 12223050: cc: Fix tile manager shutdown by aborting all pending uploads. (Closed)

Created:
7 years, 10 months ago by reveman
Modified:
7 years, 10 months ago
Reviewers:
nduca, epenner, piman
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Fix tile manager shutdown by aborting all pending uploads. CHROMIUM_async_pixel_transfers doesn't have a way to abort a pending upload but deleting texture and query has the same effect. BUG=173704 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181952

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -9 lines) Patch
M cc/resource_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resource_provider.cc View 1 3 chunks +40 lines, -8 lines 0 comments Download
M cc/tile_manager.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/tile_manager.cc View 1 2 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
reveman
Hi, this should fix tile manager shutdown when context is still alive.
7 years, 10 months ago (2013-02-08 09:26:25 UTC) #1
piman
LGTM+nit https://codereview.chromium.org/12223050/diff/1/cc/resource_provider.cc File cc/resource_provider.cc (right): https://codereview.chromium.org/12223050/diff/1/cc/resource_provider.cc#newcode57 cc/resource_provider.cc:57: // Set texture properties. nit: no need for ...
7 years, 10 months ago (2013-02-11 19:32:49 UTC) #2
reveman
https://codereview.chromium.org/12223050/diff/1/cc/resource_provider.cc File cc/resource_provider.cc (right): https://codereview.chromium.org/12223050/diff/1/cc/resource_provider.cc#newcode57 cc/resource_provider.cc:57: // Set texture properties. On 2013/02/11 19:32:49, piman wrote: ...
7 years, 10 months ago (2013-02-11 20:29:57 UTC) #3
nduca
lgtm
7 years, 10 months ago (2013-02-11 21:52:01 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-11 22:00:46 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698