Issue 12223014: Add path traversal protection to Move and CopyFile too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12223014: Add path traversal protection to Move and CopyFile too. (Closed)

Created:
7 years, 10 months ago by Chris Evans

Modified:
7 years, 10 months ago

Reviewers:
cpu_(ooo_6.6-7.5), darin (slow to review)

CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Add path traversal protection to Move and CopyFile too. These functions are used a lot in IPC receivers to manage storage. See http://src.chromium.org/viewvc/chrome?view=rev&revision=175642 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181045

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -8 lines)			Patch
M	base/file_util.h	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	base/file_util.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	base/file_util_mac.mm	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	base/file_util_posix.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/file_util_unittest.cc	View	1 2	3 chunks	+15 lines, -3 lines	0 comments	Download
M	base/file_util_win.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Chris Evans

Continuing your good work sir, @cpu I'll tag it with a bug before landing. Would ...

7 years, 10 months ago (2013-02-06 01:10:36 UTC) #1

LGTM