Cleanup: Introduce AsyncFileTestHelper for testing with async file/quota operations

Introduce AsyncFileTestHelper for testing with async file/quota operations

Also gradually deprecate FileUtilHelper since its code is no longer
used in the actual code path (used only in unittests).

BUG=146215
TEST=content_unittests:LocalFileSystem*
TBR=jam@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181278

[kinuko, 2013-02-05 12:33:01]

The body of AsyncFileTestHelper is mostly just extracted from
LocalFileSystemCrossOperationTest (so that they can be used in other tests).
PTL thanks,

[nhiroki, 2013-02-05 15:12:02]

https://codereview.chromium.org/12223006/diff/1/webkit/fileapi/async_file_tes...
File webkit/fileapi/async_file_test_helper.h (right):

https://codereview.chromium.org/12223006/diff/1/webkit/fileapi/async_file_tes...
webkit/fileapi/async_file_test_helper.h:29: // Performs Copy from |src| and
|dest| and returns the status code.
nit: "... from |src| to |dest| and ..." ?

https://codereview.chromium.org/12223006/diff/1/webkit/fileapi/async_file_tes...
webkit/fileapi/async_file_test_helper.h:34: // Performs Move from |src| and
|dest| and returns the status code.
ditto.

https://codereview.chromium.org/12223006/diff/1/webkit/fileapi/async_file_tes...
webkit/fileapi/async_file_test_helper.h:67: // Returns true if a file exists at
|url| with size |size|. If |size| is
nit: "with size |size|" -> "with |size|"

https://codereview.chromium.org/12223006/diff/1/webkit/fileapi/async_file_tes...
webkit/fileapi/async_file_test_helper.h:69: // existenc).
nit: s/existenc/existence/

[tzik, 2013-02-06 04:37:07]

Looks good. Could you look into test failure?
Seems to just need test expectation update.

[kinuko, 2013-02-06 11:39:59]

Thanks, updated the header comment & test expectations.

https://codereview.chromium.org/12223006/diff/1/webkit/fileapi/async_file_tes...
File webkit/fileapi/async_file_test_helper.h (right):

https://codereview.chromium.org/12223006/diff/1/webkit/fileapi/async_file_tes...
webkit/fileapi/async_file_test_helper.h:29: // Performs Copy from |src| and
|dest| and returns the status code.
On 2013/02/05 15:12:02, nhiroki wrote:
> nit: "... from |src| to |dest| and ..." ?

Done.

https://codereview.chromium.org/12223006/diff/1/webkit/fileapi/async_file_tes...
webkit/fileapi/async_file_test_helper.h:34: // Performs Move from |src| and
|dest| and returns the status code.
On 2013/02/05 15:12:02, nhiroki wrote:
> ditto.

Done.

https://codereview.chromium.org/12223006/diff/1/webkit/fileapi/async_file_tes...
webkit/fileapi/async_file_test_helper.h:67: // Returns true if a file exists at
|url| with size |size|. If |size| is
On 2013/02/05 15:12:02, nhiroki wrote:
> nit: "with size |size|" -> "with |size|"

Done.

https://codereview.chromium.org/12223006/diff/1/webkit/fileapi/async_file_tes...
webkit/fileapi/async_file_test_helper.h:69: // existenc).
On 2013/02/05 15:12:02, nhiroki wrote:
> nit: s/existenc/existence/

Done.

[tzik, 2013-02-07 06:41:39]

lgtm

[nhiroki, 2013-02-07 06:43:00]

lgtm

https://codereview.chromium.org/12223006/diff/9003/webkit/fileapi/local_file_...
File webkit/fileapi/local_file_system_operation_unittest.cc (right):

https://codereview.chromium.org/12223006/diff/9003/webkit/fileapi/local_file_...
webkit/fileapi/local_file_system_operation_unittest.cc:600:
FILE_PATH_LITERAL("NewFile")));
nit: fix indentation (10 -> 6)

[kinuko, 2013-02-07 09:03:22]

Thanks!

https://codereview.chromium.org/12223006/diff/9003/webkit/fileapi/local_file_...
File webkit/fileapi/local_file_system_operation_unittest.cc (right):

https://codereview.chromium.org/12223006/diff/9003/webkit/fileapi/local_file_...
webkit/fileapi/local_file_system_operation_unittest.cc:600:
FILE_PATH_LITERAL("NewFile")));
On 2013/02/07 06:43:00, nhiroki wrote:
> nit: fix indentation (10 -> 6)

Done.

[commit-bot: I haz the power, 2013-02-07 09:06:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/12223006/6003

[commit-bot: I haz the power, 2013-02-07 09:06:50]

Presubmit check for 12223006-6003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content

Presubmit checks took 1.7s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[kinuko, 2013-02-07 09:12:12]

Adding jam@ for adding two test files into content/content_tests.gypi. Thanks!

[commit-bot: I haz the power, 2013-02-07 09:13:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/12223006/6003

[commit-bot: I haz the power, 2013-02-07 10:28:19]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...