Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1222243002: remove call to didModifyBackingTexture (Closed)

Created:
5 years, 5 months ago by reed2
Modified:
5 years, 5 months ago
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

remove call to didModifyBackingTexture, unneeded now that we are using SkSurface::getTextureHandle() BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198287

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M Source/platform/graphics/ImageBuffer.cpp View 1 1 chunk +1 line, -7 lines 0 comments Download
M Source/platform/graphics/ImageBufferSurface.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222243002/1
5 years, 5 months ago (2015-07-02 20:05:49 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222243002/1
5 years, 5 months ago (2015-07-03 19:27:39 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222243002/20001
5 years, 5 months ago (2015-07-03 21:20:36 UTC) #8
reed2
ptal this is the last reference to getTopDevice! after this, only one remaining reference to ...
5 years, 5 months ago (2015-07-04 01:51:37 UTC) #11
Justin Novosad
lgtm
5 years, 5 months ago (2015-07-04 02:53:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222243002/20001
5 years, 5 months ago (2015-07-04 13:28:08 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=198287
5 years, 5 months ago (2015-07-04 13:32:18 UTC) #15
Ken Russell (switch to Gerrit)
5 years, 5 months ago (2015-07-06 20:10:37 UTC) #16
Message was sent while issue was closed. 
LGTM after the fact.

Powered by Google App Engine
This is Rietveld 408576698