Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: src/objects.cc

Issue 1222223002: Remove temporary hack re deleting hidden properties (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index e53df91d0ba67f99ba9bb1f422a4b68ff9fed72d..1d829af047cdd68761bef5c90471b6522c9b6a17 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -5231,14 +5231,6 @@ MaybeHandle<Object> JSReceiver::DeleteProperty(LookupIterator* it,
return it->factory()->false_value();
}
- Handle<JSObject> holder = it->GetHolder<JSObject>();
- // TODO(verwaest): Remove this temporary compatibility hack when blink
- // tests are updated.
- if (!holder.is_identical_to(receiver) &&
- !(receiver->IsJSGlobalProxy() && holder->IsJSGlobalObject())) {
- return it->factory()->true_value();
- }
-
it->Delete();
if (is_observed) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698