Issue 1222203012: Re-add -Wno-missing-braces on win clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1222203012: Re-add -Wno-missing-braces on win clang. (Closed)

Created:
5 years, 5 months ago by dcheng

Modified:
5 years, 5 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Re-add -Wno-missing-braces on win clang. ANGLE needs a roll to fix one last instance of this warning, but the roll is currently blocked. Disable this warning again until ANGLE can be successfully rolled to fda3ec747c3dca037b961c7f8c04a81766f37007. BUG=505297 R=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/c38a1f71038e5f0a5565b42e30b8985870b49286

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	build/config/compiler/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nico

(and `git cl land` is ok for this i think, doesn't affect any non-fyi bots ...

5 years, 5 months ago (2015-07-08 16:57:54 UTC) #4

dcheng

Committed patchset #1 (id:1) manually as c38a1f71038e5f0a5565b42e30b8985870b49286 (presubmit successful).

5 years, 5 months ago (2015-07-08 17:01:05 UTC) #5

dcheng

5 years, 5 months ago (2015-07-09 20:43:45 UTC) #6

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1226143007/ by dcheng@chromium.org.

The reason for reverting is: ANGLE has rolled in
https://crrev.com/01b5c82d06fcbddd7556ea848ba803b72c61811c.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages