[Sync] Add priority preferences datatype for mobile

[Sync] Add priority preferences datatype for mobile

This also adds support for the normal preferences datatype because that's
the one hardcoded as a user selectable type, but because it doesn't have a
datatype controller on mobile, it will never be turned on (and it therefore
won't be preferred, so we won't receive invalidations for it).

BUG=505542
Committed: https://crrev.com/2b0454e851d76ab224b68df692855da75e08c534
Cr-Commit-Position: refs/heads/master@{#338379}

[Nicolas Zea, 2015-07-08 20:33:18]

zea@chromium.org changed reviewers:
+ maxbogue@chromium.org

[Nicolas Zea, 2015-07-08 20:33:19]

Max, PTAL

[maxbogue, 2015-07-08 23:10:38]

Looking good; just one question to make sure I understand things.

https://codereview.chromium.org/1222203008/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java
(right):

https://codereview.chromium.org/1222203008/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:574:
mSyncSettings.setChecked(syncTypes.contains(ModelType.PRIORITY_PREFERENCE));
Just to clarify my understanding: this is PRIORITY_PREFERENCE because when we
tell sync to enable the PREFERENCE datatype, it will try to do both but only
succeed for PRIORITY_PREFERENCE?

[Nicolas Zea, 2015-07-08 23:20:35]

https://codereview.chromium.org/1222203008/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java
(right):

https://codereview.chromium.org/1222203008/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java:574:
mSyncSettings.setChecked(syncTypes.contains(ModelType.PRIORITY_PREFERENCE));
On 2015/07/08 23:10:38, maxbogue wrote:
> Just to clarify my understanding: this is PRIORITY_PREFERENCE because when we
> tell sync to enable the PREFERENCE datatype, it will try to do both but only
> succeed for PRIORITY_PREFERENCE?

Correct. The PREFERENCE type doesn't have a data type controller registered, so
will never actually be treated as "preferred".

[maxbogue, 2015-07-09 00:11:05]

lgtm

[Nicolas Zea, 2015-07-09 00:14:02]

zea@chromium.org changed reviewers:
+ newt@chromium.org, nyquist@chromium.org

[Nicolas Zea, 2015-07-09 00:14:04]

+Tommy FYI, +Newt for owners

[newt (away), 2015-07-09 00:23:51]

sync_customization_preferences.xml, SyncCustomizationFragment.java, and
android_chrome_strings.grd lgtm.

nyquist should look at ProfileSyncService.java and
SyncCustomizationFragmentTest.java.

[nyquist, 2015-07-10 20:59:26]

this code lgtm. I read the bug for explanations of why. please include me in the
discussion if/when we add support for other preferences.

I am assuming that you've tested that there are none of these preferences that
really have an affect an android clients yet.

[Nicolas Zea, 2015-07-10 21:09:35]

On 2015/07/10 20:59:26, nyquist wrote:
> this code lgtm. I read the bug for explanations of why. please include me in
the
> discussion if/when we add support for other preferences.
> 
> I am assuming that you've tested that there are none of these preferences that
> really have an affect an android clients yet.

Yep, they're all ChromeOS for now.

[Nicolas Zea, 2015-07-10 21:09:43]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2015-07-10 21:10:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1222203008/60001

[commit-bot: I haz the power, 2015-07-10 22:11:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-10 22:12:07]

Patchset 4 (id:??) landed as
https://crrev.com/2b0454e851d76ab224b68df692855da75e08c534
Cr-Commit-Position: refs/heads/master@{#338379}