Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: src/full-codegen.h

Issue 1222203007: Use FullCodeGenerator::EmitGlobalVariableLoad() where possible to avoid code duplication. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebasing Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/full-codegen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen.h
diff --git a/src/full-codegen.h b/src/full-codegen.h
index a2d23f069dafe1b8f1a3834a1d22cac71e307369..b4294f585606625b12804a918d3df9a1f0fcc61f 100644
--- a/src/full-codegen.h
+++ b/src/full-codegen.h
@@ -552,7 +552,9 @@ class FullCodeGenerator: public AstVisitor {
TypeofState typeof_state,
Label* slow,
Label* done);
- void EmitVariableLoad(VariableProxy* proxy);
+ void EmitGlobalVariableLoad(VariableProxy* proxy, TypeofState typeof_state);
+ void EmitVariableLoad(VariableProxy* proxy,
+ TypeofState typeof_state = NOT_INSIDE_TYPEOF);
void EmitAccessor(Expression* expression);
@@ -654,7 +656,6 @@ class FullCodeGenerator: public AstVisitor {
void CallLoadIC(ContextualMode mode, LanguageMode language_mode = SLOPPY,
TypeFeedbackId id = TypeFeedbackId::None());
- void CallGlobalLoadIC(Handle<String> name);
void CallStoreIC(TypeFeedbackId id = TypeFeedbackId::None());
void SetFunctionPosition(FunctionLiteral* fun);
« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698