Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1222203007: Use FullCodeGenerator::EmitGlobalVariableLoad() where possible to avoid code duplication. (Closed)

Created:
5 years, 5 months ago by Igor Sheludko
Modified:
5 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use FullCodeGenerator::EmitGlobalVariableLoad() where possible to avoid code duplication. Committed: https://crrev.com/f043ab861839402d45af3724611671daf6a798c0 Cr-Commit-Position: refs/heads/master@{#29520}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : other platforms #

Patch Set 4 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -455 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 6 chunks +28 lines, -55 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 6 chunks +28 lines, -53 lines 0 comments Download
M src/full-codegen.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 1 2 chunks +16 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 6 chunks +28 lines, -59 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 6 chunks +28 lines, -54 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 2 6 chunks +28 lines, -56 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 2 6 chunks +28 lines, -54 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 6 chunks +28 lines, -58 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 2 6 chunks +28 lines, -59 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Igor Sheludko
PTAL
5 years, 5 months ago (2015-07-07 13:40:22 UTC) #3
Jakob Kummerow
LGTM. Remove ALL the duplication!
5 years, 5 months ago (2015-07-07 14:44:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222203007/80001
5 years, 5 months ago (2015-07-07 14:44:50 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 5 months ago (2015-07-07 15:04:50 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 15:05:00 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f043ab861839402d45af3724611671daf6a798c0
Cr-Commit-Position: refs/heads/master@{#29520}

Powered by Google App Engine
This is Rietveld 408576698