Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1222203004: PlzNavigate: Do not send synchronous navigations from the renderer to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment refactoring Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/navigation_params.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 2e7d77a987884907027c9592b092779f2be946ff..c269f7d5348c2f63d3cc3e8e2d24268932998167 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -4329,10 +4329,12 @@ WebNavigationPolicy RenderFrameImpl::DecidePolicyForNavigation(
return blink::WebNavigationPolicyIgnore;
}
- // PlzNavigate: send the request to the browser if needed.
+ // PlzNavigate: if the navigation is not synchronous, send it to the browser.
+ // This includes navigations with no request being sent to the network stack.
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableBrowserSideNavigation) &&
- info.urlRequest.checkForBrowserSideNavigation()) {
+ info.urlRequest.checkForBrowserSideNavigation() &&
+ ShouldMakeNetworkRequestForURL(url)) {
BeginNavigation(&info.urlRequest);
return blink::WebNavigationPolicyIgnore;
}
« no previous file with comments | « content/common/navigation_params.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698