content/browser/frame_host/render_frame_host_impl.cc - Issue 1222203004: PlzNavigate: Do not send synchronous navigations from the renderer to the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1222203004: PlzNavigate: Do not send synchronous navigations from the renderer to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment refactoring Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index e24f00c89d80c4dae79df2a3701932b0324d1dfa..205ee606cbd8beb87e0ed619e8c97ceeab424f9c 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -1791,7 +1791,7 @@ void RenderFrameHostImpl::CommitNavigation(

const CommonNavigationParams& common_params,

const RequestNavigationParams& request_params) {

DCHECK((response && body.get()) ||

- !NavigationRequest::ShouldMakeNetworkRequest(common_params.url));

+ !ShouldMakeNetworkRequestForURL(common_params.url));

UpdatePermissionsForNavigation(common_params, request_params);

// Get back to a clean state, in case we start a new navigation without

« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/common/navigation_params.h » ('j') | no next file with comments »