Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1222203004: PlzNavigate: Do not send synchronous navigations from the renderer to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change test Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index b5d31369efca8643be54f111442b1b4e374f9069..bb205b0e7dd6f35dd3842cabb3b8c6bada7d0eb5 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -673,7 +673,7 @@ void NavigatorImpl::CommitNavigation(FrameTreeNode* frame_tree_node,
NavigationRequest* navigation_request = frame_tree_node->navigation_request();
DCHECK(navigation_request);
DCHECK(response ||
- !NavigationRequest::ShouldMakeNetworkRequest(
+ !CommonNavigationParams::ShouldMakeNetworkRequest(
navigation_request->common_params().url));
// HTTP 204 (No Content) and HTTP 205 (Reset Content) responses should not
@@ -814,7 +814,7 @@ void NavigatorImpl::RequestNavigation(
// is synchronous and same-site) then NavigationRequest::BeginNavigation
// should be directly called instead.
if (should_dispatch_beforeunload &&
- NavigationRequest::ShouldMakeNetworkRequest(
+ CommonNavigationParams::ShouldMakeNetworkRequest(
navigation_request->common_params().url)) {
navigation_request->SetWaitingForRendererResponse();
frame_tree_node->current_frame_host()->DispatchBeforeUnload(true);

Powered by Google App Engine
This is Rietveld 408576698