PlzNavigate: Do not send synchronous navigations from the renderer to the browser.

content/common/navigation_params.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/navigation_params.h"
 
+#include "base/command_line.h"
 #include "base/memory/ref_counted_memory.h"
+#include "content/public/common/content_switches.h"
 
 namespace content {
 
+bool ShouldMakeNetworkRequestForURL(const GURL& url) {
+  // Data and Javascript urls should not make network requests.

[nasko, 2015/07/06 11:06:16]

If the comment is aiming to list the cases for no network requests, then it is
missing about:blank URLs.

I think this should become more generic function, as we don't want to send
synchronous navigations to the browser process either. For example,
pushState/popState are not something we will generate an IPC for, just satisfy
the synchronous navigation in the renderer and only send a
DidCommitProvisionalLoad IPC.

[Fabrice (no longer in Chrome), 2015/07/06 12:45:09]

I modified the comment to clarify.

+  // TODO(clamy): same document navigations should not make network requests.
+  CHECK(base::CommandLine::ForCurrentProcess()->HasSwitch(

[clamy, 2015/07/03 15:02:23]

nit: put the check above the comments, as they relate directly to the return
line.

[Fabrice (no longer in Chrome), 2015/07/06 12:45:09]

Done.

+      switches::kEnableBrowserSideNavigation));
+  return !url.SchemeIs(url::kDataScheme) && url != GURL(url::kAboutBlankURL) &&
+         !url.SchemeIs(url::kJavaScriptScheme);
+}
+
 CommonNavigationParams::CommonNavigationParams()
     : transition(ui::PAGE_TRANSITION_LINK),
       navigation_type(FrameMsg_Navigate_Type::NORMAL),
       allow_download(true),
       report_type(FrameMsg_UILoadMetricsReportType::NO_REPORT) {
 }
 
 CommonNavigationParams::CommonNavigationParams(
     const GURL& url,
     const Referrer& referrer,
@@ skipping 115 matching lines @@
     const RequestNavigationParams& request_params)
     : common_params(common_params),
       start_params(start_params),
       request_params(request_params) {
 }
 
 NavigationParams::~NavigationParams() {
 }
 
 }  // namespace content