PlzNavigate: Do not send synchronous navigations from the renderer to the browser.

content/common/navigation_params.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_NAVIGATION_PARAMS_H_
 #define CONTENT_COMMON_NAVIGATION_PARAMS_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 24 matching lines @@
                          const Referrer& referrer,
                          ui::PageTransition transition,
                          FrameMsg_Navigate_Type::Value navigation_type,
                          bool allow_download,
                          base::TimeTicks ui_timestamp,
                          FrameMsg_UILoadMetricsReportType::Value report_type,
                          const GURL& base_url_for_data_url,
                          const GURL& history_url_for_data_url);
   ~CommonNavigationParams();
 
+  // Helper function to determine if the navigation request to |url| should be
+  // sent to the network stack. It will not be sent for data URLs or JavaScript
+  // URLs, cases where no network request needs to be made.
+  static bool ShouldMakeNetworkRequest(const GURL& url);

[clamy, 2015/07/03 11:41:44]

A static method inside a struct strikes me as odd. I would rather have it
outside of any class/struct (it can remain in this file), with a name such as
ShouldMakeNetworkRequestForURL.

Also the comment should precise that this should ONLY be used with PlzNavigate.

[Fabrice (no longer in Chrome), 2015/07/03 14:55:36]

Done.

+
   // The URL to navigate to.
   // PlzNavigate: May be modified when the navigation is ready to commit.
   GURL url;
 
   // The URL to send in the "Referer" header field. Can be empty if there is
   // no referrer.
   Referrer referrer;
 
   // The type of transition.
   ui::PageTransition transition;
@@ skipping 198 matching lines @@
   ~NavigationParams();
 
   CommonNavigationParams common_params;
   StartNavigationParams start_params;
   RequestNavigationParams request_params;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_NAVIGATION_PARAMS_H_