Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: src/libplatform/default-platform.cc

Issue 1222203003: Fix data-race in default implementation of delayed task. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/libplatform/default-platform.h" 5 #include "src/libplatform/default-platform.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <queue> 8 #include <queue>
9 9
10 #include "src/base/logging.h" 10 #include "src/base/logging.h"
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 142
143 void DefaultPlatform::CallOnForegroundThread(v8::Isolate* isolate, Task* task) { 143 void DefaultPlatform::CallOnForegroundThread(v8::Isolate* isolate, Task* task) {
144 base::LockGuard<base::Mutex> guard(&lock_); 144 base::LockGuard<base::Mutex> guard(&lock_);
145 main_thread_queue_[isolate].push(task); 145 main_thread_queue_[isolate].push(task);
146 } 146 }
147 147
148 148
149 void DefaultPlatform::CallDelayedOnForegroundThread(Isolate* isolate, 149 void DefaultPlatform::CallDelayedOnForegroundThread(Isolate* isolate,
150 Task* task, 150 Task* task,
151 double delay_in_seconds) { 151 double delay_in_seconds) {
152 base::LockGuard<base::Mutex> guard(&lock_);
152 double deadline = MonotonicallyIncreasingTime() + delay_in_seconds; 153 double deadline = MonotonicallyIncreasingTime() + delay_in_seconds;
153 main_thread_delayed_queue_[isolate].push(std::make_pair(deadline, task)); 154 main_thread_delayed_queue_[isolate].push(std::make_pair(deadline, task));
154 } 155 }
155 156
156 157
157 double DefaultPlatform::MonotonicallyIncreasingTime() { 158 double DefaultPlatform::MonotonicallyIncreasingTime() {
158 return base::TimeTicks::HighResolutionNow().ToInternalValue() / 159 return base::TimeTicks::HighResolutionNow().ToInternalValue() /
159 static_cast<double>(base::Time::kMicrosecondsPerSecond); 160 static_cast<double>(base::Time::kMicrosecondsPerSecond);
160 } 161 }
161 } } // namespace v8::platform 162 } } // namespace v8::platform
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698