Bluetooth UI: A "connecting" overlay is shown after enter a pin code.

Bluetooth UI: A "connecting" overlay is shown after enter a pin code.

This fix shows the same "connecting to <device>" dialog after the user
enters a pin code or a passkey. Before we were showing only the settings
while the connection was still in progress.

BUG=chromium-os:38450
TEST=Attempt to connect to a device that requires to enter a pin code, enter it, and see the connecting dialog message again.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181243

[deymo, 2013-02-06 02:38:39]

This is the implementation of the option b) of what I suggested in
crosbug.com/38450 . This option indeed makes a transition between messages, so
it's easier to see.
keybuk and kevers can review it.

dbeam@, I need an OWNER review for this.
Thanks.

[kevers, 2013-02-06 20:09:39]

LGTM with nit.  Will need OWNERS approval.

https://codereview.chromium.org/12222004/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.h
(right):

https://codereview.chromium.org/12222004/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.h:139: void
DeviceConnecting(device::BluetoothDevice* device);
Nit.  Undocumented argument.

[Dan Beam, 2013-02-07 00:15:46]

lgtm

https://codereview.chromium.org/12222004/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc
(right):

https://codereview.chromium.org/12222004/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc:413: if
(params) {
optional nit: remove curlies

[deymo, 2013-02-07 02:01:20]

Thanks for the comments!! Patch set 2 fixes those.

https://codereview.chromium.org/12222004/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc
(right):

https://codereview.chromium.org/12222004/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc:413: if
(params) {
On 2013/02/07 00:15:46, Dan Beam wrote:
> optional nit: remove curlies

Done.

https://codereview.chromium.org/12222004/diff/1/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.h
(right):

https://codereview.chromium.org/12222004/diff/1/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.h:139: void
DeviceConnecting(device::BluetoothDevice* device);
On 2013/02/06 20:09:39, kevers wrote:
> Nit.  Undocumented argument.

Done.

[commit-bot: I haz the power, 2013-02-07 03:32:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/deymo@chromium.org/12222004/1003

[commit-bot: I haz the power, 2013-02-07 07:20:14]

Change committed as 181243