Rebase ConfirmBubbleViews on DialogDelegateView.

chrome/browser/ui/views/confirm_bubble_views_unittest.cc

Index: chrome/browser/ui/views/confirm_bubble_views_unittest.cc
diff --git a/chrome/browser/ui/views/confirm_bubble_views_unittest.cc b/chrome/browser/ui/views/confirm_bubble_views_unittest.cc
index 8995e76e67e81596dca8ec1eaea7caf4f363b775..31f79e45985e4f25c4b39838e9b5e6a8fbaa33c9 100644
--- a/chrome/browser/ui/views/confirm_bubble_views_unittest.cc
+++ b/chrome/browser/ui/views/confirm_bubble_views_unittest.cc
@@ -26,17 +26,9 @@ TEST_F(ConfirmBubbleViewsTest, CreateAndClose) {
   bool model_deleted = false;
   TestConfirmBubbleModel* model =
       new TestConfirmBubbleModel(&model_deleted, NULL, NULL, NULL);
-  ConfirmBubbleViews* bubble =
-      new ConfirmBubbleViews(parent_widget->GetNativeView(),
-                             gfx::Point(12, 34),
-                             model);
-  views::BubbleDelegateView::CreateBubble(bubble);
-  bubble->Show();
-
-  // We're anchored to a point, not a specific view or widget.
-  EXPECT_EQ("12,34", bubble->anchor_point().ToString());
-  EXPECT_FALSE(bubble->anchor_view());
-  EXPECT_FALSE(bubble->anchor_widget());
+  ConfirmBubbleViews* bubble = new ConfirmBubbleViews(model);
+  gfx::NativeView parent = parent_widget->GetNativeView();
+  views::DialogDelegateView::CreateDialogWidget(bubble, NULL, parent)->Show();

[rpetterson, 2013/02/12 00:28:20]

You don't need any checks about placement here?

[msw, 2013/02/12 00:40:12]

There is no anchor view/point to check since it's no longer a bubble. Dialogs
are roughly centered on the parent window, but when this gets converted to a
constrained window, it'll be placed like:
https://docs.google.com/a/google.com/folder/d/0B6x6iYCtKinEUTFOWUJFTWJFSTA/ed...

This subclass probably doesn't need special testing for its inherited placement
behavior, which the constrained window code ought to check. I added Mike Wittman
to the review in case he has any thoughts on this.

[Mike Wittman, 2013/02/12 00:49:57]

Ultimately tab-constrained dialog positioning will be handled within the new
WebContentsModalDialogManager, so there shouldn't be any need to test
positioning at the individual dialog level.

 
   // Clean up.
   bubble->GetWidget()->CloseNow();