Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Issue 12222002: MSVC manifests should use processorArchitecture="*" (Closed)

Created:
7 years, 10 months ago by jschuh
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

MSVC manifests should use processorArchitecture="*" This is inferred from the binary itself, and specifying it here breaks the Win64 build. BUG=166496 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180801

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/app/chrome.dll.manifest View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome.exe.manifest View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/win/create_installer_archive.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jschuh
With this change (and a sandbox fix) we can actually run gmail on Win64 Chrome.
7 years, 10 months ago (2013-02-05 01:55:40 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm why do we need to change this in two places? grrr
7 years, 10 months ago (2013-02-05 02:03:11 UTC) #2
grt (UTC plus 2)
On 2013/02/05 01:55:40, Justin Schuh wrote: > With this change (and a sandbox fix) we ...
7 years, 10 months ago (2013-02-05 16:48:11 UTC) #3
jschuh
On 2013/02/05 16:48:11, grt wrote: > lgtm, too, although MSDN says that processorArchitecture is optional. ...
7 years, 10 months ago (2013-02-05 16:54:21 UTC) #4
jschuh
On 2013/02/05 16:54:21, Justin Schuh wrote: > On 2013/02/05 16:48:11, grt wrote: > > lgtm, ...
7 years, 10 months ago (2013-02-05 18:16:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12222002/1
7 years, 10 months ago (2013-02-05 18:18:00 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/app/chrome.dll.manifest: While running patch -p0 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 10 months ago (2013-02-05 18:18:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12222002/9001
7 years, 10 months ago (2013-02-05 21:57:28 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-05 21:57:29 UTC) #9
Failed to apply patch for chrome/app/chrome.dll.manifest:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file chrome/app/chrome.dll.manifest
  Hunk #1 FAILED at 2.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/app/chrome.dll.manifest.rej

Patch:       chrome/app/chrome.dll.manifest
Index: chrome/app/chrome.dll.manifest
===================================================================
--- chrome/app/chrome.dll.manifest	(revision 180783)
+++ chrome/app/chrome.dll.manifest	(working copy)
@@ -2,7 +2,7 @@
 <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
   <dependency>
     <dependentAssembly>
-      <assemblyIdentity type="Win32" name="Microsoft.Windows.Common-Controls"
version="6.0.0.0" processorArchitecture="X86" publicKeyToken="6595b64144ccf1df"
language="*"></assemblyIdentity>
+      <assemblyIdentity type="Win32" name="Microsoft.Windows.Common-Controls"
version="6.0.0.0" processorArchitecture="*" publicKeyToken="6595b64144ccf1df"
language="*"></assemblyIdentity>
     </dependentAssembly>
   </dependency>
 </assembly>

Powered by Google App Engine
This is Rietveld 408576698