Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1222193007: Don't initialize NSS in Cast renderers for the chimera build. (Closed)

Created:
5 years, 5 months ago by davidben
Modified:
5 years, 5 months ago
Reviewers:
Ryan Sleevi, gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't initialize NSS in Cast renderers for the chimera build. Cast has no need for NSS in renderers apart from the common crypto bits (WebCrypto, //crypto), both of which will be BoringSSL in the chimera. Prepare for that be switching to !USE_OPENSSL rather than USE_NSS_CERTS. BUG=506323 Committed: https://crrev.com/4229ed54eee27211cfa6e34840e8c3bcbefdb582 Cr-Commit-Position: refs/heads/master@{#337835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chromecast/renderer/cast_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (2 generated)
davidben
gunsch: Doug told me you folks have no special need for NSS in renderer anymore? ...
5 years, 5 months ago (2015-07-07 23:20:01 UTC) #2
gunsch
+Doug, can you confirm? That seems accurate to me, though.
5 years, 5 months ago (2015-07-07 23:28:05 UTC) #3
gunsch
+Doug, can you confirm? That seems accurate to me, though.
5 years, 5 months ago (2015-07-07 23:28:06 UTC) #4
dougsteed
On 2015/07/07 23:28:06, gunsch wrote: > +Doug, can you confirm? That seems accurate to me, ...
5 years, 5 months ago (2015-07-08 02:53:21 UTC) #5
davidben
On 2015/07/08 02:53:21, dougsteed wrote: > On 2015/07/07 23:28:06, gunsch wrote: > > +Doug, can ...
5 years, 5 months ago (2015-07-08 04:59:24 UTC) #6
gunsch
lgtm
5 years, 5 months ago (2015-07-08 05:46:16 UTC) #7
Ryan Sleevi
lgtm
5 years, 5 months ago (2015-07-08 11:08:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222193007/1
5 years, 5 months ago (2015-07-08 16:26:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 16:30:59 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 16:32:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4229ed54eee27211cfa6e34840e8c3bcbefdb582
Cr-Commit-Position: refs/heads/master@{#337835}

Powered by Google App Engine
This is Rietveld 408576698