Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1222193006: Remove race in DeclarativeContentApiTest.RulesPersistence test (Closed)

Created:
5 years, 5 months ago by matthewtff.asm
Modified:
5 years, 5 months ago
Reviewers:
battre
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, Mike Wittman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove race in DeclarativeContentApiTest.RulesPersistence test BUG= Committed: https://crrev.com/28218513bf9580515b03c73ab786c27844e9b40b Cr-Commit-Position: refs/heads/master@{#339432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M chrome/test/data/extensions/api_test/declarative_content/persistence/background.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (4 generated)
matthewtff.asm
On 2015/07/07 11:23:16, matthewtff.asm wrote: > mailto:matthewtff@yandex-team.ru changed reviewers: > + mailto:battre@chromium.org On my mac ...
5 years, 5 months ago (2015-07-07 11:26:12 UTC) #2
battre
+wittman FYI LGTM
5 years, 5 months ago (2015-07-07 14:17:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222193006/1
5 years, 5 months ago (2015-07-07 14:25:39 UTC) #5
commit-bot: I haz the power
The author matthewtff@yandex-team.ru has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-07 14:25:42 UTC) #6
commit-bot: I haz the power
The author matthewtff@yandex-team.ru has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-07 14:27:06 UTC) #7
commit-bot: I haz the power
The author matthewtff@yandex-team.ru has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-07 14:31:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222193006/1
5 years, 5 months ago (2015-07-20 10:19:19 UTC) #11
commit-bot: I haz the power
The author matthewtff@yandex-team.ru has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-20 10:19:22 UTC) #12
matthewtff.asm
On 2015/07/07 14:31:13, commit-bot: I haz the power wrote: > The author mailto:matthewtff@yandex-team.ru has not ...
5 years, 5 months ago (2015-07-20 10:20:08 UTC) #13
commit-bot: I haz the power
The author matthewtff@yandex-team.ru has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-20 10:31:48 UTC) #14
commit-bot: I haz the power
The author matthewtff@yandex-team.ru has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-20 11:01:51 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 11:27:47 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/28218513bf9580515b03c73ab786c27844e9b40b Cr-Commit-Position: refs/heads/master@{#339432}
5 years, 5 months ago (2015-07-20 11:28:35 UTC) #17
Mike Wittman
5 years, 5 months ago (2015-07-21 19:20:41 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1247743004/ by wittman@chromium.org.

The reason for reverting is: Breaks linux clang tot bot
(https://crbug.com/512506) and causes flakiness on Vista Tests bot
(https://crbug.com/512431).

BUG=512506, 512431.

Powered by Google App Engine
This is Rietveld 408576698