Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: content/browser/tracing/tracing_controller_impl.cc

Issue 1222153004: [tracing] Simplify and improve thread-hopping logic of memory-infra (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re dsinclair #7 Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/memory_dump_manager_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tracing/tracing_controller_impl.cc
diff --git a/content/browser/tracing/tracing_controller_impl.cc b/content/browser/tracing/tracing_controller_impl.cc
index ce9b854c841b0ed415d69702ed862b9d32b7dd83..2ea35c186b5ee6a2a69216a786cb4aacba6a9d62 100644
--- a/content/browser/tracing/tracing_controller_impl.cc
+++ b/content/browser/tracing/tracing_controller_impl.cc
@@ -866,6 +866,10 @@ void TracingControllerImpl::OnBrowserProcessMemoryDumpDone(uint64 dump_guid,
bool success) {
DCHECK_GT(pending_memory_dump_ack_count_, 0);
--pending_memory_dump_ack_count_;
+ if (!success) {
+ ++failed_memory_dump_count_;
+ DLOG(WARNING) << "Global memory dump aborted on the current process";
+ }
FinalizeGlobalMemoryDumpIfAllProcessesReplied();
}
« no previous file with comments | « base/trace_event/memory_dump_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698