base/tracked_objects.h - Issue 1222123002: Fix a race in ThreadLocalStorage::StaticSlot::initialized which triggers a TSAN error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/tracked_objects.h

Issue 1222123002: Fix a race in ThreadLocalStorage::StaticSlot::initialized which triggers a TSAN error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix MSVC compile warning. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/tracked_objects.h

diff --git a/base/tracked_objects.h b/base/tracked_objects.h

index 8f8379409dbfb031377b9ecded008fd4a0c3ea52..c1e070800c856a11eb0737dcac436ee4aa60c4fa 100644

--- a/base/tracked_objects.h

+++ b/base/tracked_objects.h

@@ -12,6 +12,7 @@

#include <utility>

#include <vector>

+#include "base/atomicops.h"

#include "base/base_export.h"

#include "base/basictypes.h"

#include "base/containers/hash_tables.h"

@@ -661,7 +662,7 @@ class BASE_EXPORT ThreadData {

static base::LazyInstance<base::Lock>::Leaky list_lock_;

// We set status_ to SHUTDOWN when we shut down the tracking service.

- static Status status_;

+ static base::subtle::Atomic32 status_;

// Link to next instance (null terminated list). Used to globally track all

// registered instances (corresponds to all registered threads where we keep

« no previous file with comments | « base/threading/thread_local_storage.cc ('k') | base/tracked_objects.cc » ('j') | no next file with comments »