Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 12221162: Fix for Issue 8460. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
index 916b4db455b607d3cadbc8515509c6cd046c6906..264334af9fc924e9a14b6a3c8d9a86de49e92c54 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
@@ -3010,6 +3010,16 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
<HInstruction>[]));
}
+ void handleForeignDartObjectJsConstructorFunction(Send node) {
+ if (!node.arguments.isEmpty) {
+ compiler.cancel('Too many arguments', node: node.argumentsNode);
+ }
+ String jsClassReference = backend.namer.isolateAccess(compiler.objectClass);
+ push(new HForeign(new DartString.literal(jsClassReference),
+ HType.UNKNOWN,
+ <HInstruction>[]));
+ }
+
visitForeignSend(Send node) {
Selector selector = elements.getSelector(node);
SourceString name = selector.name;
@@ -3031,6 +3041,8 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
stack.add(addConstantString(node, backend.namer.operatorIsPrefix()));
} else if (name == const SourceString('JS_OPERATOR_AS_PREFIX')) {
stack.add(addConstantString(node, backend.namer.operatorAsPrefix()));
+ } else if (name == const SourceString('JS_DART_OBJECT_CONSTRUCTOR')) {
+ handleForeignDartObjectJsConstructorFunction(node);
} else {
throw "Unknown foreign: ${selector}";
}

Powered by Google App Engine
This is Rietveld 408576698