Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 12221161: gpu: Enable async uploads again. (Closed)

Created:
7 years, 10 months ago by epenner
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

gpu: Enable async uploads again. Random changes have been breaking Android bots. It turns out async uploads isn't the issue, but rather simply that old ICS Imagination drivers crash on glTexSubImage2D (very consistantly). This enables async uploads again, but also puts in a work-around in our work-around :). When we fallback to glTexSubImage2D, we use glTexImage2D instead. BUG=174440 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182299

Patch Set 1 #

Patch Set 2 : Adjust DCHECKs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M ui/gl/async_pixel_transfer_delegate_android.cc View 1 4 chunks +18 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epenner
Ptal.
7 years, 10 months ago (2013-02-13 01:12:41 UTC) #1
epenner
On 2013/02/13 01:12:41, epenner wrote: > Ptal. +Daniel. I'd recommend all changes to this file ...
7 years, 10 months ago (2013-02-13 01:30:28 UTC) #2
epenner
On 2013/02/13 01:30:28, epenner wrote: > On 2013/02/13 01:12:41, epenner wrote: > > Ptal. > ...
7 years, 10 months ago (2013-02-13 01:31:05 UTC) #3
apatrick_chromium
lgtm
7 years, 10 months ago (2013-02-13 20:00:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/12221161/4001
7 years, 10 months ago (2013-02-13 20:08:58 UTC) #5
nduca
7 years, 10 months ago (2013-02-13 20:38:15 UTC) #6
Message was sent while issue was closed.
Committed manually as r182299.

Powered by Google App Engine
This is Rietveld 408576698