Issue 12221155: Turning the new launcher back on by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12221155: Turning the new launcher back on by default (Closed)

Created:
7 years, 10 months ago by Mr4D (OOO till 08-26)

Modified:
7 years, 10 months ago

Reviewers:
James Cook

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Turning the new launcher back on by default BUG=171453 TEST=unit tests TBR=jamescook Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182337

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -30 lines)			Patch
M	ash/ash_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/ash_switches.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_browsertest.cc	View	3 chunks	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mr4D (OOO till 08-26)

James, this is only for the preparation when the M27 floodgates will be opened. :) ...

7 years, 10 months ago (2013-02-12 23:35:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/12221155/1

7 years, 10 months ago (2013-02-13 23:44:00 UTC) #3

commit-bot: I haz the power

7 years, 10 months ago (2013-02-13 23:44:05 UTC) #4

Presubmit check for 12221155-1 failed and returned exit status 1.

INFO:root:Found 6 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ash/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/ash/launcher

Presubmit checks took 1.6s to calculate.

Expand Messages | Collapse Messages