Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 12221144: Make zoom using ctrl+mouse wheel work in win aura. Windows -non-aura had a hack that was a layering… (Closed)

Created:
7 years, 10 months ago by jam
Modified:
7 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, yusukes+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Make zoom using ctrl+mouse wheel work in win aura. Windows non-aura had a hack that was a layering violation which sent a custom win32 message from RenderWidgetHostViewWin to WebContentsViewWin. Instead do this properly from RenderWidgetHostImpl to its delegate (WebContentsImpl), which works for both aura and non-aura windows builds. BUG=175055 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -47 lines) Patch
M base/win/win_util.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +1 line, -19 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_win.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M ui/views/win/hwnd_message_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
7 years, 10 months ago (2013-02-12 16:46:42 UTC) #1
Ben Goodger (Google)
7 years, 10 months ago (2013-02-12 17:36:43 UTC) #2
nice! lgtm

Powered by Google App Engine
This is Rietveld 408576698