Actually prevent sending notifications from apps.

Actually prevent sending notifications from apps.

It looks up the current preference through DesktopNotificationService
and reports failures when it's stopped.

BUG=161094
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182138

[miket_OOO, 2013-02-11 23:04:20]

lgtm

https://codereview.chromium.org/12221127/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/notification/notification_api.cc (right):

https://codereview.chromium.org/12221127/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/notification/notification_api.cc:219: if
(!IsNotificationApiEnabled()) {
If you think this should be enforced for all NotificationApiFunctions, you could
change RunImpl() to do this automatically. I think it's also OK as-is.

[Jun Mukai, 2013-02-12 01:09:02]

https://codereview.chromium.org/12221127/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/notification/notification_api.cc (right):

https://codereview.chromium.org/12221127/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/notification/notification_api.cc:219: if
(!IsNotificationApiEnabled()) {
On 2013/02/11 23:04:20, miket wrote:
> If you think this should be enforced for all NotificationApiFunctions, you
could
> change RunImpl() to do this automatically. I think it's also OK as-is.

That sounds reasonable. Fixed the code based on your idea. Can you take another
look?

[miket_OOO, 2013-02-13 00:19:54]

Nice. Thanks!

[commit-bot: I haz the power, 2013-02-13 00:46:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/12221127/5001

[commit-bot: I haz the power, 2013-02-13 06:17:47]

Change committed as 182138