Remove SminessPropagator and FlowGraphTypePropagator and all associated infrastructure and fields.

runtime/vm/object.cc

Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 5ed01da4238e3e232df74d24283e39fa627986a4..c7c2970dde313d8a11a196207ee78e037fa05dda 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -2185,12 +2185,13 @@ bool Class::TypeTest(
     // Since we do not truncate the type argument vector of a subclass (see
     // below), we only check a prefix of the proper length.
     // Check for covariance.
-    if (other_type_arguments.IsNull() ||
-        other_type_arguments.IsRawInstantiatedRaw(len)) {
+    if (other_type_arguments.IsNull() || other_type_arguments.IsRaw(len)) {

[Vyacheslav Egorov (Google), 2013/02/11 17:31:07]

This function should compute if result of type test for any values of type
arguments thus it is incorrect to assume that they will be replaced by dynamic.
Otherwise given a instantiated type A<int> and uninstantiated type A<T> it will
say that A<int> <: A<T> and A<int> << A<T>, while in practice T can be replaced
with for example bool.

[regis, 2013/02/11 19:51:49]

Good catch. I think the reason we were doing this was for function parameter
type tests, where the generics were not instantiated. Now, we have a separate
function (TestParameterType) calling this one after properly instantiating the
generics.

       return true;
     }
-    if (type_arguments.IsNull() ||
-        type_arguments.IsRawInstantiatedRaw(len)) {
+    if (type_arguments.IsNull() || type_arguments.IsRaw(len)) {

[Vyacheslav Egorov (Google), 2013/02/11 17:31:07]

This function should compute if result of type test for any values of type
arguments thus it is incorrect to assume that they will be replaced by dynamic.
Otherwise given an instantiated type A<T> and uninstantiated type A<int> it will
say that A<T> <: A<int> and A<T> << A<int>, while in practice T can be replaced
with for example bool.

+      // Other type can't be more specific than this one because for that
+      // it would have to have all dynamic type arguments which is checked
+      // above.
       return test_kind == kIsSubtypeOf;
     }
     return type_arguments.TypeTest(test_kind,