Add a modal confirmation dialog to the enterprise profile sign-in flow.

chrome/browser/signin/signin_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/signin_manager.h"
 
 #include <string>
 #include <vector>
 
 #include "base/callback_helpers.h"
@@ skipping 10 matching lines @@
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/signin/about_signin_internals.h"
 #include "chrome/browser/signin/about_signin_internals_factory.h"
 #include "chrome/browser/signin/signin_global_error.h"
 #include "chrome/browser/signin/signin_internals_util.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/signin/token_service.h"
 #include "chrome/browser/signin/token_service_factory.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/sync_prefs.h"
-#include "chrome/browser/ui/global_error/global_error_service.h"
 #include "chrome/browser/ui/global_error/global_error_service_factory.h"
+#include "chrome/browser/ui/host_desktop.h"
+#include "chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 #include "google_apis/gaia/gaia_auth_fetcher.h"
 #include "google_apis/gaia/gaia_auth_util.h"
 #include "google_apis/gaia/gaia_constants.h"
 #include "google_apis/gaia/gaia_urls.h"
 #include "net/cookies/cookie_monster.h"
@@ skipping 672 matching lines @@
     CompleteSigninAfterPolicyLoad();
     return;
   }
 
   // Stash away a copy of our CloudPolicyClient (should not already have one).
   DCHECK(!policy_client_);
   policy_client_.swap(client);
 
   DVLOG(1) << "Policy registration succeeded: dm_token="
            << policy_client_->dm_token();
-  // TODO(dconnelly): Prompt user for whether they want to create a new profile
-  // or not (http://crbug.com/171236), and either call SignOut() if they cancel,
-  // TransferCredentialsToNewProfile() to create a new profile, or
-  // LoadPolicyWithCachedClient() if they want to sign in for the current
-  // profile.
-  // For now, just call LoadPolicyWithCachedClient() to immediately load policy
-  // into the current profile and finish signing in.
-  LoadPolicyWithCachedClient(policy_client_.Pass());
+
+  // Allow user to create a new profile before continuing with sign-in.
+  ProfileSigninConfirmationDialog::ShowDialog(
+      possibly_invalid_username_,
+      base::Bind(&SigninManager::SignOut,
+                 weak_pointer_factory_.GetWeakPtr()),
+      base::Bind(&SigninManager::TransferCredentialsToNewProfile,
+                 weak_pointer_factory_.GetWeakPtr()),
+      base::Bind(&SigninManager::LoadPolicyWithCachedClient,
+                 weak_pointer_factory_.GetWeakPtr(),
+                 base::Passed(policy_client_.Pass())));

[Andrew T Wilson (Slow), 2013/02/10 20:47:26]

So, this is the root of the DCHECK you are hitting - policy_client_.Pass()
clears policy_client_ and moves the pointer into a scoped_ptr within the
callback you are creating.

I'd say the right way to proceed is to change LoadPolicyWithCachedClient() to
not take any parameters, and just used the cached policy_client_ instead. It
means that CompleteSigninForNewProfile() will need to move policy_client_ to the
newly created profile (see my next comment).

[dconnelly, 2013/02/11 09:35:16]

Done.

 }
 
 void SigninManager::LoadPolicyWithCachedClient(
     scoped_ptr<policy::CloudPolicyClient> client) {
   DCHECK(client);
   policy::UserPolicySigninService* policy_service =
       policy::UserPolicySigninServiceFactory::GetForProfile(profile_);
   policy_service->FetchPolicyForSignedInUser(
       client.Pass(),
       base::Bind(&SigninManager::OnPolicyFetchComplete,
@@ skipping 37 matching lines @@
   // Wait until the profile is initialized before we transfer credentials.
   if (status == Profile::CREATE_STATUS_INITIALIZED) {
     DCHECK(!possibly_invalid_username_.empty());
     DCHECK(policy_client_);
     // Sign in to the just-created profile and fetch policy for it.
     SigninManager* signin_manager =
         SigninManagerFactory::GetForProfile(profile);
     DCHECK(signin_manager);
     signin_manager->possibly_invalid_username_ = possibly_invalid_username_;
     signin_manager->last_result_ = last_result_;
     signin_manager->temp_oauth_login_tokens_ = temp_oauth_login_tokens_;

[Andrew T Wilson (Slow), 2013/02/10 20:47:26]

So, when you change LoadPolicyWithCachedClient() to not take any parameters,
you'll want to add:

signin_manager->policy_client_(policy_client_);

to transfer ownership of the client to the new profile.

[dconnelly, 2013/02/11 09:35:16]

Done.

     signin_manager->LoadPolicyWithCachedClient(policy_client_.Pass());
     // Allow sync to start up if it is not overridden by policy.
     browser_sync::SyncPrefs prefs(profile->GetPrefs());
     prefs.SetSyncSetupCompleted();
 
     // We've transferred our credentials to the new profile - sign out.
     SignOut();
   }
 }
 #endif
@@ skipping 115 matching lines @@
                     NotifySigninValueChanged(field, value));
 }
 
 void SigninManager::NotifyDiagnosticsObservers(
     const TimedSigninStatusField& field,
     const std::string& value) {
   FOR_EACH_OBSERVER(SigninDiagnosticsObserver,
                     signin_diagnostics_observers_,
                     NotifySigninValueChanged(field, value));
 }