Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 12221088: Sync FileSystem: Drop is_fetching_changes_ flag and completion_callback (Closed)

Created:
7 years, 10 months ago by tzik
Modified:
7 years, 10 months ago
Reviewers:
kinuko
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Sync FileSystem: Drop is_fetching_changes_ flag and completion_callback BUG=175047

Patch Set 1 #

Patch Set 2 : drop flag and callback #

Patch Set 3 : +has_unfetched_remote_change #

Patch Set 4 : +return after FetchChangesForIncrementalSync call #

Patch Set 5 : postpone token acquisition #

Patch Set 6 : modify delay, disable retry on FetchRemoteChange kicked on notification #

Patch Set 7 : run StartBatchSync on REMOTE_SERVICE_TEMPORARY_UNAVAILABLE case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -57 lines) Patch
M chrome/browser/sync_file_system/drive_file_sync_service.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service.cc View 1 2 3 4 5 6 11 chunks +15 lines, -54 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tzik
7 years, 10 months ago (2013-02-08 14:49:40 UTC) #1
PTAL

Powered by Google App Engine
This is Rietveld 408576698