Translate: split language code typo correction to apply unit tests.

chrome/renderer/translate_helper_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/translate_helper.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 typedef testing::Test TranslateHelperTest;
 
+// Tests that well-known language code typos are fixed.
+TEST_F(TranslateHelperTest, LanguageCodeTypoCorrection) {
+  std::string language;
+
+  // Strip the second and later codes.
+  language = std::string("ja,en");
+  TranslateHelper::CorrectLanguageCodeTypo(&language);
+  EXPECT_EQ(0, language.compare("ja"));

[sky, 2013/02/12 17:30:07]

EXPECT_EQ("ja", language) same pattern for other tests.

[Takashi Toyoshima, 2013/02/14 08:00:18]

Done.

+
+  // Replace dash with hyphen.
+  language = std::string("ja_JP");
+  TranslateHelper::CorrectLanguageCodeTypo(&language);
+  EXPECT_EQ(0, language.compare("ja-JP"));
+
+  // Correct wrong cases.
+  language = std::string("JA-jp");
+  TranslateHelper::CorrectLanguageCodeTypo(&language);
+  EXPECT_EQ(0, language.compare("ja-JP"));
+}
+
 // Tests that synonym language code is converted to one used in supporting list.
 TEST_F(TranslateHelperTest, LanguageCodeSynonyms) {
   std::string language;
 
   language = std::string("nb");
   TranslateHelper::ConvertLanguageCodeSynonym(&language);
   EXPECT_EQ(0, language.compare("no"));
 
   language = std::string("he");
   TranslateHelper::ConvertLanguageCodeSynonym(&language);
   EXPECT_EQ(0, language.compare("iw"));
 
   language = std::string("jv");
   TranslateHelper::ConvertLanguageCodeSynonym(&language);
   EXPECT_EQ(0, language.compare("jw"));
 
   language = std::string("fil");
   TranslateHelper::ConvertLanguageCodeSynonym(&language);
   EXPECT_EQ(0, language.compare("tl"));
 }