Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 12221082: Add gear menu to /downloads and /external_storage. (Closed)

Created:
7 years, 10 months ago by mtomasz
Modified:
7 years, 10 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Add gear menu to /downloads and /external_storage. Before, only Drive had a gear menu. This menu contains remaining space and help item. For consistency, the same button should appear on any other volume, but without Drive related items. As a result, the help menu item as well as the remaining size are in one place for each volume. TEST=Check the gear button in Downloads, Drive and some removeable media. It should contain only 2 items for non-Drive volumes: space and help. Check if space is correct. BUG=172813 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181841

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Total comments: 1

Patch Set 3 : Fixed help links. #

Patch Set 4 : Addressed comments. #

Patch Set 5 : Cleaned up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -99 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 11 chunks +33 lines, -41 lines 0 comments Download
M chrome/browser/resources/file_manager/js/drive_banners.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 3 4 9 chunks +61 lines, -33 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager_commands.js View 1 2 3 4 6 chunks +23 lines, -8 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 1 2 3 4 3 chunks +13 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtomasz
@yoshiki: PTAL.
7 years, 10 months ago (2013-02-08 05:41:51 UTC) #1
yoshiki
lgtm with nit https://codereview.chromium.org/12221082/diff/1001/chrome/browser/resources/file_manager/js/drive_banners.js File chrome/browser/resources/file_manager/js/drive_banners.js (right): https://codereview.chromium.org/12221082/diff/1001/chrome/browser/resources/file_manager/js/drive_banners.js#newcode537 chrome/browser/resources/file_manager/js/drive_banners.js:537: var node = this.document_.querySelector('body'); You can ...
7 years, 10 months ago (2013-02-08 06:15:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12221082/6001
7 years, 10 months ago (2013-02-08 06:38:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12221082/12001
7 years, 10 months ago (2013-02-08 10:54:17 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=97678
7 years, 10 months ago (2013-02-08 11:58:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12221082/12001
7 years, 10 months ago (2013-02-12 01:00:11 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 03:00:00 UTC) #7
Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698