Disable normal default extensions in case of managed users

Disable normal default extensions in case of managed users

Added managed users only default extensions (will be used to push policy locally)
We need such changes on Chrome OS because it is the only way to apply whitelist
but it looks like similar code makes sense for all other platforms too.

BUG=171922
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182444

[Dmitry Polukhin, 2013-02-07 12:39:26]

Bernhard, please take a look. I would like to check with you about general
approach before sending this patch to extensions OWNERs or move further. I
changes code common for all platforms in managed mode.

[Dmitry Polukhin, 2013-02-08 12:48:29]

Bernhard, friendly ping, could you please take a look to this CL?

[Bernhard Bauer, 2013-02-08 13:38:18]

LGTM w/ nits:

https://codereview.chromium.org/12221065/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/external_provider_impl.cc (right):

https://codereview.chromium.org/12221065/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/external_provider_impl.cc:44: #if
defined(ENABLE_MANAGED_USERS)
Nit: Could you move this before the OS_* #ifdefs, so they're alphabetical?

https://codereview.chromium.org/12221065/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/external_provider_impl.cc:376:
check_admin_permissions_on_mac),
Nit: alignment.

[Dmitry Polukhin, 2013-02-11 07:55:22]

+thakis@ for OWNER review in chrome/common/*
+asargent@ for OWNER review in chrome/browser/extensions/*

https://codereview.chromium.org/12221065/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/external_provider_impl.cc (right):

https://codereview.chromium.org/12221065/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/external_provider_impl.cc:44: #if
defined(ENABLE_MANAGED_USERS)
On 2013/02/08 13:38:18, Bernhard Bauer wrote:
> Nit: Could you move this before the OS_* #ifdefs, so they're alphabetical?

Done.

https://codereview.chromium.org/12221065/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/external_provider_impl.cc:376:
check_admin_permissions_on_mac),
On 2013/02/08 13:38:18, Bernhard Bauer wrote:
> Nit: alignment.

Done.

[Nico, 2013-02-11 15:47:06]

https://codereview.chromium.org/12221065/diff/5/chrome/common/chrome_paths.cc
File chrome/common/chrome_paths.cc (right):

https://codereview.chromium.org/12221065/diff/5/chrome/common/chrome_paths.cc...
chrome/common/chrome_paths.cc:507:
cur.Append(FILE_PATH_LITERAL("default_apps"));
Huh? Why this change? This is a bug, no? Does this even compile? I thought our
compilers catch this.

[Dmitry Polukhin, 2013-02-11 17:43:52]

https://codereview.chromium.org/12221065/diff/5/chrome/common/chrome_paths.cc
File chrome/common/chrome_paths.cc (right):

https://codereview.chromium.org/12221065/diff/5/chrome/common/chrome_paths.cc...
chrome/common/chrome_paths.cc:507:
cur.Append(FILE_PATH_LITERAL("default_apps"));
On 2013/02/11 15:47:06, Nico wrote:
> Huh? Why this change? This is a bug, no? Does this even compile? I thought our
> compilers catch this.

Oops... It is unintended change. I accidentally removed part of the line. Thanks
a lot for noticing this!

[Nico, 2013-02-11 17:45:19]

chrome/common lgtm

[asargent_no_longer_on_chrome, 2013-02-11 18:53:24]

extensions part LGTM


+cc grv just as FYI, since he did some work on this code a little while ago.

[Gaurav, 2013-02-11 19:06:14]

LGTM

https://codereview.chromium.org/12221065/diff/8002/chrome/browser/extensions/...
File chrome/browser/extensions/external_provider_impl.cc (right):

https://codereview.chromium.org/12221065/diff/8002/chrome/browser/extensions/...
chrome/browser/extensions/external_provider_impl.cc:383: if
(!is_chromeos_demo_session && !is_managed_profile) {
lines 383-470 can be moved to a block

if (!is_managed_profile) {
 ...
}

and inside if's can be removed.

[Dmitry Polukhin, 2013-02-13 14:41:02]

Bernhard, please take a look to new changes added in
chrome/browser/managed_mode/managed_user_service.cc to make this CL work after
your your latest changes.

https://codereview.chromium.org/12221065/diff/8002/chrome/browser/extensions/...
File chrome/browser/extensions/external_provider_impl.cc (right):

https://codereview.chromium.org/12221065/diff/8002/chrome/browser/extensions/...
chrome/browser/extensions/external_provider_impl.cc:383: if
(!is_chromeos_demo_session && !is_managed_profile) {
On 2013/02/11 19:06:14, Gaurav wrote:
> lines 383-470 can be moved to a block
> 
> if (!is_managed_profile) {
>  ...
> }
> 
> and inside if's can be removed.

Done.

[Bernhard Bauer, 2013-02-13 14:49:56]

chrome/browser/managed_mode LGTM.

[commit-bot: I haz the power, 2013-02-14 08:43:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/12221065/27001