src/type-info.cc - Issue 12221064: Implement many KeyedStoreStubs using Crankshaft

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/type-info.cc

Issue 12221064: Implement many KeyedStoreStubs using Crankshaft (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Review feedback Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/type-info.cc

diff --git a/src/type-info.cc b/src/type-info.cc

index 857a55dac56f878da46eac87c75c57fcc3bb462f..4aa63abde802791fbe1acfece6088470e72e4b43 100644

--- a/src/type-info.cc

+++ b/src/type-info.cc

@@ -126,12 +126,8 @@ bool TypeFeedbackOracle::StoreIsMonomorphicNormal(TypeFeedbackId ast_id) {

if (map_or_code->IsMap()) return true;

if (map_or_code->IsCode()) {

Handle<Code> code = Handle<Code>::cast(map_or_code);

- bool standard_store =

- Code::GetKeyedAccessStoreMode(code->extra_ic_state()) ==

- STANDARD_STORE;

bool preliminary_checks =

code->is_keyed_store_stub() &&

- standard_store &&

code->ic_state() == MONOMORPHIC &&

Code::ExtractTypeFromFlags(code->flags()) == Code::NORMAL;

if (!preliminary_checks) return false;

@@ -146,10 +142,7 @@ bool TypeFeedbackOracle::StoreIsPolymorphic(TypeFeedbackId ast_id) {

Handle<Object> map_or_code = GetInfo(ast_id);

if (map_or_code->IsCode()) {

Handle<Code> code = Handle<Code>::cast(map_or_code);

- bool standard_store =

- Code::GetKeyedAccessStoreMode(code->extra_ic_state()) ==

- STANDARD_STORE;

- return code->is_keyed_store_stub() && standard_store &&

+ return code->is_keyed_store_stub() &&

code->ic_state() == POLYMORPHIC;

}

return false;