src/code-stubs.cc - Issue 12221064: Implement many KeyedStoreStubs using Crankshaft

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/code-stubs.cc

Issue 12221064: Implement many KeyedStoreStubs using Crankshaft (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Rebase Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/code-stubs.cc

diff --git a/src/code-stubs.cc b/src/code-stubs.cc

index 95bc1e99cc9f29789f2a36812c8253cff9c150ab..c8492553a09cfd0e7f46d299c5a9bdc85372f154 100644

--- a/src/code-stubs.cc

+++ b/src/code-stubs.cc

@@ -460,7 +460,7 @@ void KeyedStoreElementStub::Generate(MacroAssembler* masm) {

case EXTERNAL_FLOAT_ELEMENTS:

case EXTERNAL_DOUBLE_ELEMENTS:

case EXTERNAL_PIXEL_ELEMENTS:

- KeyedStoreStubCompiler::GenerateStoreExternalArray(masm, elements_kind_);

+ UNREACHABLE();

break;

case DICTIONARY_ELEMENTS:

KeyedStoreStubCompiler::GenerateStoreDictionaryElement(masm);