Implement many KeyedStoreStubs using Crankshaft

src/arm/stub-cache-arm.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2962 matching lines @@
     Handle<Map> receiver_map) {
   // ----------- S t a t e -------------
   //  -- r0    : value
   //  -- r1    : key
   //  -- r2    : receiver
   //  -- lr    : return address
   //  -- r3    : scratch
   // -----------------------------------
   ElementsKind elements_kind = receiver_map->elements_kind();
   bool is_js_array = receiver_map->instance_type() == JS_ARRAY_TYPE;
-  Handle<Code> stub =
-      KeyedStoreElementStub(is_js_array,
-                            elements_kind,
-                            store_mode_).GetCode(isolate());
-
-  __ DispatchMap(r2, r3, receiver_map, stub, DO_SMI_CHECK);
+  if (FLAG_compiled_keyed_stores &&
+      (receiver_map->has_fast_elements() ||
+       receiver_map->has_external_array_elements())) {
+    Handle<Code> stub = KeyedStoreFastElementStub(
+        is_js_array,
+        elements_kind,
+        store_mode_).GetCode(isolate());
+    __ DispatchMap(r2, r3, receiver_map, stub, DO_SMI_CHECK);
+  } else {
+    Handle<Code> stub =
+        KeyedStoreElementStub(is_js_array, elements_kind,
+                              store_mode_).GetCode(isolate());
+    __ DispatchMap(r2, r3, receiver_map, stub, DO_SMI_CHECK);

[Hannes Payer (out of office), 2013/03/20 10:22:35]

Can you declare Handle<Code> stube before the if/else statement and move __
DispatchMap(r2, r3, receiver_map, stub, DO_SMI_CHECK); below the if/else
statement since DispatchMap is duplicated? This should also apply to
stub-cache-ia32.cc and to stub-cache-x64.cc

[danno, 2013/03/20 11:44:10]

Done.

+  }
 
   TailCallBuiltin(masm(), MissBuiltin(kind()));
 
   // Return the generated code.
   return GetICCode(kind(), Code::NORMAL, factory()->empty_string());
 }
 
 
 Handle<Code> KeyedStoreStubCompiler::CompileStorePolymorphic(
     MapHandleList* receiver_maps,
@@ skipping 949 matching lines @@
     TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
   }
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_ARM