Allow trybot changes to run against WebKit@HEAD.

scripts/master/factory/chromium_factory.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility class to build the chromium master BuildFactory's.
 
 Based on gclient_factory.py and adds chromium-specific steps."""
 
 import os
 import re
@@ skipping 857 matching lines @@
                       project=None, factory_properties=None, gclient_deps=None,
                       enable_swarm_tests=False):
     factory_properties = (factory_properties or {}).copy()
     factory_properties['gclient_env'] = \
         factory_properties.get('gclient_env', {}).copy()
     # Defaults gyp to VS2010.
     if self._target_platform == 'win32':
       factory_properties['gclient_env'].setdefault('GYP_MSVS_VERSION', '2010')
     tests = tests or []
 
+    if slave_type == 'Trybot':
+      self._InitWebkitLatestFactorySettings(factory_properties)

[Dirk Pranke, 2013/02/07 03:42:33]

Does this imply that *all* try jobs will try to pull against ToT? Are we sure we
want that by default instead of something like LKGR or the version specified in
DEPS?

[tony, 2013/02/07 22:13:49]

No, part of the changes in chromium_step.py is to remove the
'webkit_revision':'$$WK_REV$$', from gclient config if the patch doesn't have
the magic first line.

I tested this manually, but you can also try it by running git-try --host
meatwad.sfo --port 8328 and looking at the waterfall at
http://meatwad.sfo:8028/waterfall?show=linux_layout_rel (tests fail because it's
precise).

+
     if factory_properties.get('needs_valgrind'):
       self._solutions[0].custom_deps_list = [self.CUSTOM_DEPS_VALGRIND]
     elif factory_properties.get('needs_tsan_win'):
       self._solutions[0].custom_deps_list = [self.CUSTOM_DEPS_TSAN_WIN]
     elif factory_properties.get('needs_drmemory'):
       if 'drmemory.DEPS' not in [s.name for s in self._solutions]:
         self._solutions.append(gclient_factory.GClientSolution(
             config.Master.trunk_url +
             '/deps/third_party/drmemory/drmemory.DEPS',
             'drmemory.DEPS'))
@@ skipping 438 matching lines @@
                                                build_dir=web_build_dir)
       chromium_cmd_obj.AddChromebotServer(factory_properties)
       chromium_cmd_obj.AddReliabilityTests(client_os)
     elif slave_type == 'ChromebotClient':
       chromium_cmd_obj.AddGetBuildForChromebot(client_os,
                                                extract=True,
                                                build_url=build_url)
       chromium_cmd_obj.AddChromebotClient(factory_properties)
 
     return factory