chrome/browser/ui/web_contents_modal_dialog.h - Issue 12221055: Use a uniform opaque type to represent web contents modal dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/web_contents_modal_dialog.h

Issue 12221055: Use a uniform opaque type to represent web contents modal dialogs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: disable unused webui certificate viewer on linux Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/web_contents_modal_dialog.h

diff --git a/chrome/browser/ui/web_contents_modal_dialog.h b/chrome/browser/ui/web_contents_modal_dialog.h

index 90f85885c7c39d9241c94c6bd04842ca14615270..f05264551a7361a5e5365de0cbf4ef813b2e5957 100644

--- a/chrome/browser/ui/web_contents_modal_dialog.h

+++ b/chrome/browser/ui/web_contents_modal_dialog.h

@@ -5,8 +5,7 @@

#ifndef CHROME_BROWSER_UI_WEB_CONTENTS_MODAL_DIALOG_H_

#define CHROME_BROWSER_UI_WEB_CONTENTS_MODAL_DIALOG_H_

-#include "build/build_config.h"

-#include "ui/gfx/native_widget_types.h"

+#include "chrome/browser/ui/native_web_contents_modal_dialog.h"

///////////////////////////////////////////////////////////////////////////////

// WebContentsModalDialog

@@ -29,8 +28,8 @@ class WebContentsModalDialog {

// Runs a pulse animation for the web contents modal dialog.

virtual void PulseWebContentsModalDialog() = 0;

- // Returns the native window of the web contents modal dialog.

- virtual gfx::NativeWindow GetNativeWindow() = 0;

+ // Returns the native representation of the web contents modal dialog.

+ virtual NativeWebContentsModalDialog GetNativeDialog() = 0;

protected:

virtual ~WebContentsModalDialog() {}