chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm - Issue 12221055: Use a uniform opaque type to represent web contents modal dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

Issue 12221055: Use a uniform opaque type to represent web contents modal dialogs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: disable unused webui certificate viewer on linux Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h ('k') | chrome/browser/ui/gtk/constrained_window_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

index 80ca7e0f4421ac7a6b8831cf8d0a20740028ec05..7240b9a18814d859cb9182a5ae2eb34db82b2b4e 100644

--- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

+++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm

@@ -76,9 +76,11 @@ void ConstrainedWindowMac::PulseWebContentsModalDialog() {

pulseSheet:sheet_];

}

-gfx::NativeWindow ConstrainedWindowMac::GetNativeWindow() {

- NOTREACHED();

- return nil;

+NativeWebContentsModalDialog ConstrainedWindowMac::GetNativeDialog() {

+ // TODO(wittman): Ultimately this should be changed to the

+ // ConstrainedWindowSheet pointer, in conjunction with the corresponding

+ // changes to NativeWebContentsModalDialogManagerCocoa.

+ return this;

}

void ConstrainedWindowMac::Observe(