chrome/browser/ui/views/constrained_window_views.cc - Issue 12221055: Use a uniform opaque type to represent web contents modal dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/constrained_window_views.cc

Issue 12221055: Use a uniform opaque type to represent web contents modal dialogs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add TODO Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/constrained_window_views.cc

diff --git a/chrome/browser/ui/views/constrained_window_views.cc b/chrome/browser/ui/views/constrained_window_views.cc

index 7ef32b018fd3599d96a20ea82a33c8600e069bac..b934218493a19e7821fbfe6e85b5122656b23e56 100644

--- a/chrome/browser/ui/views/constrained_window_views.cc

+++ b/chrome/browser/ui/views/constrained_window_views.cc

@@ -607,8 +607,8 @@ void ConstrainedWindowViews::FocusWebContentsModalDialog() {

void ConstrainedWindowViews::PulseWebContentsModalDialog() {

}

-gfx::NativeWindow ConstrainedWindowViews::GetNativeWindow() {

- return Widget::GetNativeWindow();

+NativeWebContentsModalDialog ConstrainedWindowViews::GetNativeDialog() {

+ return GetNativeWindow();

}

ConstrainedWindowViews* ConstrainedWindowViews::Create(