chrome/browser/ui/native_web_contents_modal_dialog.h - Issue 12221055: Use a uniform opaque type to represent web contents modal dialogs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/native_web_contents_modal_dialog.h

Issue 12221055: Use a uniform opaque type to represent web contents modal dialogs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_NATIVE_WEB_CONTENTS_MODAL_DIALOG_H_

	6 #define CHROME_BROWSER_UI_NATIVE_WEB_CONTENTS_MODAL_DIALOG_H_

	7

	8 #include "ui/gfx/native_widget_types.h"

	9

	10 #if defined(OS_MACOSX)

	11 // Use a specific type since none of the gfx::Native* types are suitable for

	12 // representing the web contents modal dialog under Cocoa.

	13 @protocol ConstrainedWindowSheet;
	sail 2013/02/07 00:46:08 I don't think this would compile if it was include I don't think this would compile if it was included from a .cc file. You could fix it by doing something like this: #ifdef __OBJC__ typedef id<ConstrainedWindowSheet> NativeWebContentsModalDialog; #else class ConstrainedWindowSheet; typedef ConstrainedWindowSheet* NativeWebContentsModalDialog; #endif Here's an example: https://code.google.com/p/chromium/codesearch#chrome/src/ui/gfx/image/image_s... If this class is never included from a .cc file on Mac then you could just do something like this instead: #if defined(OS_MACOSX) #ifdef __OBJC__ ... #else #error This header should be included from a .mm file. #endif Mike Wittman 2013/02/11 22:20:30 I've updated the ifdefs based on the code in image I've updated the ifdefs based on the code in image_skia_util_mac.h. I'm not certain this will never be included in a .cc file on Mac.
	14 typedef id<ConstrainedWindowSheet> NativeWebContentsModalDialog;

	15 #else

	16 typedef gfx::NativeWindow NativeWebContentsModalDialog;

	17 #endif

	18

	19 #endif // CHROME_BROWSER_UI_NATIVE_WEB_CONTENTS_MODAL_DIALOG_H_

OLD	NEW

« no previous file with comments | « chrome/browser/ui/gtk/constrained_window_gtk.cc ('k') | chrome/browser/ui/native_web_contents_modal_dialog_manager.h » ('j') | no next file with comments »