Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 12221052: Remove use of deprecated test methods (asynctTest/callbackDone/expectThrows).

Created:
7 years, 10 months ago by gram
Modified:
7 years, 10 months ago
Reviewers:
vsm
CC:
reviews+dom_dartlang.org
Base URL:
http://src.chromium.org/multivm/trunk/webkit/LayoutTests/dart/
Visibility:
Public.

Description

Remove use of deprecated test methods (asynctTest/callbackDone/expectThrows).

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -47 lines) Patch
M Multiscript.html View 1 chunk +3 lines, -2 lines 0 comments Download
M dom/GeolocationTest.dart View 1 1 chunk +14 lines, -16 lines 0 comments Download
M dom/Workers.dart View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M security/cross-frame-access.html View 1 2 5 chunks +26 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gram
7 years, 10 months ago (2013-02-06 22:19:48 UTC) #1
vsm
lgtm
7 years, 10 months ago (2013-02-06 22:26:57 UTC) #2
gram
PTAL. I found some errors. I haven't been able to get them to run but ...
7 years, 10 months ago (2013-02-06 23:09:09 UTC) #3
vsm
lgtm
7 years, 10 months ago (2013-02-06 23:14:45 UTC) #4
M-A Ruel
On 2013/02/06 23:14:45, vsm wrote: > lgtm FTR, multivm is not supported by the CQ.
7 years, 10 months ago (2013-02-07 17:32:57 UTC) #5
gram
7 years, 10 months ago (2013-02-07 18:05:00 UTC) #6
PTAL

Powered by Google App Engine
This is Rietveld 408576698