Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 12221025: Use NativeTabbedPaneViews in the CollectedCookiesViews dialog. (Closed)

Created:
7 years, 10 months ago by msw
Modified:
7 years, 10 months ago
Reviewers:
markusheintz_, sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Use NativeTabbedPaneViews in the CollectedCookiesViews dialog. Use NativeTabbedPaneViews instead of NativeTabbedPaneWin. (this helps unblock new dialog styling transparency) (this is the only remaining use of NativeTabbedPaneWin) See pics of the change at http://crbug.com/166075#c29 TODO(followup): Remove NativeTabbedPaneWin, cleanup TabbedPane, TabbedPaneTest, NativeTabbedPaneWrapper. TODO(followup): Match CollectedCookiesViews dialog spec. BUG=138059, 166075 TEST=Collected cookies dialog looks/behaves sane. R=markusheintz@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -21 lines) Patch
M chrome/browser/ui/views/collected_cookies_views.cc View 3 chunks +8 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Hey Markus and Scott, please take a look; thanks!
7 years, 10 months ago (2013-02-06 00:30:54 UTC) #1
sky
LGTM
7 years, 10 months ago (2013-02-06 00:42:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12221025/1
7 years, 10 months ago (2013-02-06 02:37:00 UTC) #3
commit-bot: I haz the power
Change committed as 180924
7 years, 10 months ago (2013-02-06 07:22:51 UTC) #4
markusheintz_
7 years, 10 months ago (2013-02-06 09:46:22 UTC) #5
Message was sent while issue was closed.
LGTM. Thanks a lot.

Powered by Google App Engine
This is Rietveld 408576698