src/ia32/debug-ia32.cc - Issue 1222093007: Debugger: use debug break slot to break on call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/debug-ia32.cc

Issue 1222093007: Debugger: use debug break slot to break on call. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/debug-ia32.cc

diff --git a/src/ia32/debug-ia32.cc b/src/ia32/debug-ia32.cc

index 5666cf4d22f88befd406b3fa67c7cd02a86bbff2..f0a806e3473fd5dcfcf20f59ad5c8d52c5e4a275 100644

--- a/src/ia32/debug-ia32.cc

+++ b/src/ia32/debug-ia32.cc

@@ -231,7 +231,6 @@ void DebugCodegen::GenerateSlot(MacroAssembler* masm) {

// Generate enough nop's to make space for a call instruction.

Label check_codesize;

__ bind(&check_codesize);

- __ RecordDebugBreakSlot();

__ Nop(Assembler::kDebugBreakSlotLength);

DCHECK_EQ(Assembler::kDebugBreakSlotLength,

masm->SizeOfCodeGeneratedSince(&check_codesize));