Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 1222013005: Implements WebHistoryServiceFactory on iOS (Closed)

Created:
5 years, 5 months ago by sdefresne
Modified:
5 years, 5 months ago
Reviewers:
droger
CC:
browser-components-watch_chromium.org, chromium-reviews, maniscalco+watch_chromium.org, maxbogue+watch_chromium.org, noyau+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, sdefresne+watch_chromium.org, tfarina, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implements WebHistoryServiceFactory on iOS Cleanup iOS BrowserStateKeyedService factories to follow style guide and to fix typos in the factory description comments. BUG=429756 Committed: https://crrev.com/cacc7b509a6ab9111b15ff5abc16bdd0de27d15b Cr-Commit-Position: refs/heads/master@{#337633}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -7 lines) Patch
M ios/chrome/browser/bookmarks/startup_task_runner_service_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/bookmarks/startup_task_runner_service_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/favicon/favicon_service_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/favicon/favicon_service_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/google/google_url_tracker_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/google/google_url_tracker_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/history/history_service_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/history/history_service_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/browser/history/web_history_service_factory.h View 1 chunk +46 lines, -0 lines 0 comments Download
A ios/chrome/browser/history/web_history_service_factory.cc View 1 1 chunk +74 lines, -0 lines 0 comments Download
M ios/chrome/browser/signin/signin_error_controller_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/signin_error_controller_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/sync/sync_setup_service_factory.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/undo/bookmark_undo_service_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/undo/bookmark_undo_service_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/web_data_service_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/web_data_service_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look.
5 years, 5 months ago (2015-07-07 17:08:43 UTC) #2
droger
lgtm
5 years, 5 months ago (2015-07-07 17:17:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222013005/20001
5 years, 5 months ago (2015-07-07 17:32:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-07 17:39:21 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 17:40:19 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cacc7b509a6ab9111b15ff5abc16bdd0de27d15b
Cr-Commit-Position: refs/heads/master@{#337633}

Powered by Google App Engine
This is Rietveld 408576698