Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1222013002: Concurrent sweeping of code space. (Closed)

Created:
5 years, 5 months ago by Hannes Payer (out of office)
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Concurrent sweeping of code space. BUG= Committed: https://crrev.com/3050b52f57d652dc45c8baf416e174f22dc2c159 Cr-Commit-Position: refs/heads/master@{#29456}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -27 lines) Patch
M src/frames.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 12 chunks +69 lines, -27 lines 0 comments Download
M src/heap/spaces.h View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Hannes Payer (out of office)
5 years, 5 months ago (2015-07-02 13:40:49 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-02 13:43:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222013002/60001
5 years, 5 months ago (2015-07-02 16:43:45 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-02 16:45:38 UTC) #6
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/3050b52f57d652dc45c8baf416e174f22dc2c159 Cr-Commit-Position: refs/heads/master@{#29456}
5 years, 5 months ago (2015-07-02 16:45:52 UTC) #7
Michael Achenbach
5 years, 5 months ago (2015-07-06 08:25:41 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1223763003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Increased flaky crashes. See:
https://code.google.com/p/v8/issues/detail?id=4275.

Powered by Google App Engine
This is Rietveld 408576698