Shill: Delay the ConnectToSignal call until an observer is added.

chromeos/dbus/shill_client_helper.h

Index: chromeos/dbus/shill_client_helper.h
diff --git a/chromeos/dbus/shill_client_helper.h b/chromeos/dbus/shill_client_helper.h
index b8f769c4fcf76dc0aaeb848b6584b78c7c875d72..d292065b75c7ca3b1692d0d43c359f01fec3e5c5 100644
--- a/chromeos/dbus/shill_client_helper.h
+++ b/chromeos/dbus/shill_client_helper.h
@@ -72,7 +72,9 @@ class ShillClientHelper {
   // Removes an |observer| of the PropertyChanged signal.
   void RemovePropertyChangedObserver(ShillPropertyChangedObserver* observer);
 
-  // Starts monitoring PropertyChanged signal.
+  // Starts monitoring PropertyChanged signal. If there aren't observers for the
+  // PropertyChanged signal, the actual monitoring will be delayed until the
+  // first observer is added.
   void MonitorPropertyChanged(const std::string& interface_name);
 
   // Calls a method without results.
@@ -125,6 +127,9 @@ class ShillClientHelper {
                                        const base::Value& value);
 
  private:
+  // Starts monitoring PropertyChanged signal.
+  void MonitorPropertyChangedInternal(const std::string& interface_name);
+
   // Handles the result of signal connection setup.
   void OnSignalConnected(const std::string& interface,
                          const std::string& signal,
@@ -180,6 +185,7 @@ class ShillClientHelper {
   PropertyChangedHandler property_changed_handler_;
   ObserverList<ShillPropertyChangedObserver, true /* check_empty */>
       observer_list_;
+  std::vector<std::string> monitored_interfaces_;

[hashimoto, 2013/02/13 04:01:31]

nit: Since all users are using this class for a single class, just having a
string, instead of vector<string>, may suffice. (maybe interface name should be
passed to the ctor, though it can be done in a separate patch if we are going to
merge this to M26)
another-nit: How about renaming this variable to "interfaces_to_be_monitored_"
or something?  At least, interfaces are not observed as long as they are stored
in this vector.

[deymo, 2013/02/13 05:41:07]

1st nit: The current interface doesn't prevent someone to call several times
MonitorPropertyChanged with different interfaces. With this interface, even
handling "one string or nothing" looks simpler with a vector. +1 to pass the
interface name in the constructor (but in another CL). In that other case a
boolean will be better.

2nd nit: Done.

On 2013/02/13 04:01:31, hashimoto wrote:

 
   // Note: This should remain the last member so it'll be destroyed and
   // invalidate its weak pointers before any other members are destroyed.